Re: [RFC bpf-next 2/2] bpf, mips: Add support for BPF_MOVSX in the JITs

From: Nicholas Dudar

Date: Thu Sep 03 2026 - 19:29:58 EST


Hi Johan,

On Fri, Aug 28, 2026 at 12:16 PM +0200, Johan Almbladh
<johan.almbladh@xxxxxxxxxxxxxxxxx> wrote:
> The MOV/MOVSX structure looks good in general. Some remarks on the
> implementation of individual emittor functions.

Thanks for the review. I incorporated the suggestions into v2: moved
clobber bookkeeping to the common emitter tails, grouped the 8- and 16-bit
cases using 32 - off, removed the middle returns, and used emit_sext() for
the MIPS64 MOVSX32 case.

I'll send v2 shortly.

Thanks,
Nicholas