Re: [RFC PATCH net-next 3/9] net: phy: air: type the buckpbus core on the bus and address

[Andrew Lunn]

On Sat, Aug 29, 2026 at 05:25:40AM +0000, Aleksei Sviridkin wrote:
> The buckpbus accessors only need an MDIO bus and an address, but they
> take a phy_device, which ties them to a probed PHY. An upcoming MDIO
> device driver needs the same register access before any phy_device
> exists, since it runs precisely to make the PHY presentable.
> 
> Retype the internal helpers onto (mii_bus, addr) and keep the exported
> phy_device API as page-selecting wrappers around them. The file
> already carries an mdio_device-typed accessor for the AN8811HB pbus,
> so this follows an existing direction rather than opening a new one.
> 
> No functional change.
> 
> Assisted-by: LLM
> Signed-off-by: Aleksei Sviridkin <f@xxxxxx>
> ---
>  drivers/net/phy/air_phy_lib.c | 85 +++++++++++++++++++----------------
>  1 file changed, 46 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/net/phy/air_phy_lib.c b/drivers/net/phy/air_phy_lib.c
> index 5141db19fa5e..e0fca5f285d2 100644
> --- a/drivers/net/phy/air_phy_lib.c
> +++ b/drivers/net/phy/air_phy_lib.c
> @@ -14,31 +14,32 @@
>  
>  #include "air_phy_lib.h"
>  
> -static int __air_buckpbus_reg_read(struct phy_device *phydev,
> +static int __air_buckpbus_reg_read(struct mii_bus *bus, int addr,
>  				   u32 pbus_address, u32 *pbus_data)
>  {
>  	int pbus_data_low, pbus_data_high;
>  	int ret;
>  
> -	ret = __phy_write(phydev, AIR_BPBUS_MODE, AIR_BPBUS_MODE_ADDR_FIXED);
> +	ret = __mdiobus_write(bus, addr, AIR_BPBUS_MODE,
> +			      AIR_BPBUS_MODE_ADDR_FIXED);

We have mdiodev_read() and mdiodev_write:

static inline int mdiodev_read(struct mdio_device *mdiodev, u32 regnum)
{
	return mdiobus_read(mdiodev->bus, mdiodev->addr, regnum);
}

static inline int mdiodev_write(struct mdio_device *mdiodev, u32 regnum,
				u16 val)
{
	return mdiobus_write(mdiodev->bus, mdiodev->addr, regnum, val);
}

A PHY is a superset of an mdiodev....

struct phy_device {
	struct mdio_device mdio;

	/* Information about the PHY type */
	/* And management functions */
	const struct phy_driver *drv;

So it might look better to add __mdiodev_read()/__mdiodev_write(), and
have the PHY driver pass &phydev->mdio, and the firmware download
driver can directly use its mdiodev.

	Andrew