Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths
From: Hangbin Liu
Date: Thu Sep 03 2026 - 21:31:30 EST
On Thu, Sep 03, 2026 at 02:53:29PM +0300, Nikolay Aleksandrov wrote:
> Waaait a second, it is moved after slave arr update, yes that would cause those.
> I missed it in the review, in my suggestion I specifically said it must be before
> the slave array update because it uses slave_cnt.
>
> It must be moved up. :)
Ah, bond_update_slave_arr()... I only notice the bond_xdp_set_features() and
thought all the code after netdev_ops->ndo_bpf are xdp related...
My bad, I should check the code more carefully, and do testings even with
simple change.
Hangbin