Re: [PATCH net 1/2] net: fec: don't leave a stale PTP clock pointer after unregister

Next message: Hui Su: "Re: [PATCH v2 2/2] sched/cache: Drive cache task tick from execution context"
Previous message: nirbhayykumarr: "[PATCH] misc: mei: prevent reusing disconnecting clients in mei_ioctl_connect_vtag"
In reply to: Wei Fang: "RE: [PATCH net 1/2] net: fec: don't leave a stale PTP clock pointer after unregister"
Next in thread: Shengzhuo Wei: "[PATCH net 2/2] net: fec: free the PPS interrupt before tearing down the PHC and netdev"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Shengzhuo Wei

Date: Fri Sep 04 2026 - 00:03:31 EST

On 2026-09-04 03:15, Wei Fang wrote:
> Why not move fec_ptp_stop() after unregister_netdev()?

Good point. I was focused on making the PHC index lookup safe
independently of the teardown ordering and followed the approach used by
similar fixes, so I overlooked the simpler solution here.

Moving fec_ptp_stop() after unregister_netdev() is cleaner and restores
the proper lifetime ordering. I will rework patch 1 accordingly and drop
the ptp_clock_index_by_dev() change in v2.

Thanks,
Shengzhuo