Re: [PATCH v4 4/5] x86/amd_node: Skip SMN setup on Hygon Fam18h models 0x04-0x08

[Lin Wang]

On 9/4/2026 1:36 PM, Borislav Petkov wrote:
> > Would this ordering address the Sashiko concern?
> This should address my concerns - we can then see what Sashiko complains
> about and sanity-check it.
>
> And I explained it already - you basically carve out/split/separate Hygon
> paths from AMD paths and you basically forget X86_FEATURE_ZEN. I don't care if
> Zen and Hygon systems are/were the same or almost the same.
>
> Obviously they will start diverging so you can carve out Hygon-specific pieces
> now and then keep adding new functionality to them. Just as if this is
> a completely different x86 CPU.
>
> This way, the code is untangled from the very beginning and there won't be any
> ugly and unmaintainable
>
> 	if (vendor)
>
> sprinkling all over the x86 AMD code where neither you nor we will be happy
> about going forward.

Hi Boris,

Thanks, this is clear.

I understand that Hygon should use its own node and SMN implementation
rather than adding Hygon-specific handling to the AMD paths. I will
follow this separation in v5 and in the later driver support.

My concern was how to address the Sashiko finding without making the
later Hygon driver support a prerequisite for the node layer. This
ordering resolves that concern.

For v5, I will remove the existing Hygon matches which rely on the AMD
NB or SMN implementation before making those initializers AMD-only.

Thanks & Br,

Lin