Re: [PATCH v3 2/2] soundwire: dmi-quirks: drop the ghost RT1320 on the Surface Pro 11 (Intel)

[Pierre-Louis Bossart]

On 8/30/26 17:15, Sergey Lebedev wrote:
> The Microsoft Surface Pro 11 for Business (Intel, Lunar Lake) carries a
> single physical RT1320 amplifier on link 0 and describes it twice:
> 
>   SWRA  _ADR 0x000030025D132000   SDCA class 0
>   SWRB  _ADR 0x000030025D132001   SDCA class 1
> 
> Identical apart from the class id: same link, same manufacturer, part and
> version, same unique id 0. The part reports class 1, so only SWRB
> enumerates. SWRA never attaches on any boot or firmware version tested,
> including the November 2025 bundle.
> 
> The ghost is not harmless. It consumes an amplifier index in
> find_acpi_adr_device(), so the real part is named "rt1320-2" and the stock
> sof-soundwire UCM profile enables switches on a device that is not there.
> Its endpoints also reach create_sdw_dailink(), which builds DAI link names
> from link id and function type alone; the ghost declares the same SmartMic
> function as the real part, so the card fails to register at all:
> 
>   sysfs: cannot create duplicate filename
>     '.../sof_sdw/SDW0-Capture-SmartMic'
>   kobject_add_internal failed for SDW0-Capture-SmartMic with -EEXIST
>   sof_sdw sof_sdw: probe with driver sof_sdw failed with error -12
> 
> Remap its _ADR to zero so sdw_acpi_find_slaves() never creates the
> peripheral, which is how ghost devices are handled already - see
> ghost_realtek and global_ghost_adr in this file. Both failures then
> disappear, because neither path is reached.
> 
> Matched on DMI_PRODUCT_SKU rather than the product name. A later batch of
> the same model could carry a different RT1320 version, which would change
> the _ADR; keying on the SKU keeps this remap to the hardware it was
> verified on, and follows dell_sku_0A3E above.
> 
> Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>
> Suggested-by: Bard Liao <bard.liao@xxxxxxxxx>
> Signed-off-by: Sergey Lebedev <lsa.uz@xxxxx>

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxx>

the other 1/2 patch should be skipped for now until the problem with the
NEEDS_INITIALIZATION flag is understood.
> ---
>  drivers/soundwire/dmi-quirks.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
> index d75037558..8b3c5c8d1 100644
> --- a/drivers/soundwire/dmi-quirks.c
> +++ b/drivers/soundwire/dmi-quirks.c
> @@ -111,6 +111,25 @@ static const struct adr_remap ghost_realtek[] = {
>  	{}
>  };
>  
> +/*
> + * The Microsoft Surface Pro 11 (Intel) describes its single physical RT1320
> + * amplifier twice on link 0, as two _ADR entries differing only in SDCA class
> + * id and sharing the same unique id. Only the class 1 entry enumerates; the
> + * class 0 entry is a ghost.
> + *
> + * Matched on the product SKU rather than the product name: a later batch of the
> + * same model could carry a different RT1320 version, which would change the
> + * _ADR. Keying on the SKU keeps this remap to the hardware it was verified on.
> + */
> +static const struct adr_remap microsoft_sp11_intel[] = {
> +	/* ghost rt1320 on link0 */
> +	{
> +		0x000030025d132000ull,
> +		0x0000000000000000ull
> +	},
> +	{}
> +};
> +
>  static const struct dmi_system_id adr_remap_quirk_table[] = {
>  	/* TGL devices */
>  	{
> @@ -207,6 +226,15 @@ static const struct dmi_system_id adr_remap_quirk_table[] = {
>  		},
>  		.driver_data = (void *)ghost_realtek,
>  	},
> +	/* LNL devices */
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_SKU,
> +					"Surface_Pro_11th_Edition_With_Intel_For_Business_2103")
> +		},
> +		.driver_data = (void *)microsoft_sp11_intel,
> +	},
>  	{}
>  };
>