Re: [PATCH v3 0/4] mmc: sdhci_am654: Fix DDR50 mode for cards without tuning support
From: Ulf Hansson
Date: Fri Sep 04 2026 - 05:55:56 EST
On Fri, Aug 7, 2026 at 1:08 PM Diogo Ivo (Schneider Electric)
<diogo.ivo@xxxxxxxxxxx> wrote:
>
> DDR50 mode is not required to support the tuning command CMD19 by the
> eMMC/SD specification, meaning that calibration may fail on cards that
> do not implement it. This series fixes four issues discovered when
> using such cards:
>
> - Patch 1 moves the tuning_loop counter from a persistent struct field
> to a local variable, preventing failed tuning attempts from depleting
> the retry budget across calls.
>
> - Patch 2 ensures the command/data line reset is always performed
> after tuning, even on failure, preventing stale data in the
> controller buffer.
>
> - Patch 3 clears the ITAPDLY enable and delay values on tuning
> failure so that leftover calibration values do not interfere with
> subsequent I/O.
>
> - Patch 4 falls back to the DT-provided itap delay value for DDR50
> when tuning fails in this mode, making a best-effort attempt at a
> known-good delay being programmed.
>
> Together these changes make DDR50 functional on TI J721E SoCs with
> cards that lack CMD19 tuning support. This second version addresses
> all comments from Sashiko, which I found to be correct.
>
> Signed-off-by: Diogo Ivo (Schneider Electric) <diogo.ivo@xxxxxxxxxxx>
> ---
> Changes in v3:
> - Collect R-b from Judith and A-b from Adrian
> - Add debug print when applying DT fallback values (Patch 4)
> - Link to v2: https://patch.msgid.link/20260803-am654-sdhci-v2-0-a5ee5be86133@xxxxxxxxxxx
>
The series applied for fixes, thanks!
Note that, I added a fixes/stable tag to patch1 as well since the
other patches depend on it.
Kind regards
Uffe