Re: [PATCH net-next] ppp: pass private data to channel callbacks
From: Andrew Lunn
Date: Fri Sep 04 2026 - 09:19:07 EST
On Fri, Sep 04, 2026 at 01:39:49PM +0800, Qingfang Deng wrote:
> On 2026/9/4 11:57, Jiri Slaby wrote:
> > Hi,
> >
> > On 04. 09. 26, 5:11, Qingfang Deng wrote:
> > > PPP channel callbacks receive struct ppp_channel only to retrieve the
> > > driver's private pointer. Pass that pointer directly instead.
> >
> > We had type checking at least. What's the purpose of this patch, actually?
>
> The goal is to unify the two channel structs and make it owned by the
> generic PPP layer.
The commit message is about "Why?". Please add this to the commit
message.
Andrew
---
pw-bot: cr