Re: [PATCH v2 0/5] firmware/clk: arm_scpi hardening (leak, OPP bounds, cpufreq)

[Sudeep Holla]

On Tue, 28 Jul 2026 09:04:02 +0800, Xixin Liu wrote:
> Thanks for reviewing v1.
> 
> This v2 hardens the OF SCPI firmware and clock paths against a few
> real defects found while reviewing linux-next:
> 
>   1) device_node leak in scpi_dev_domain_id() after
>      of_parse_phandle_with_args()
>   2) DVFS OPP count from SCP trusted beyond MAX_DVFS_OPPS (OOB read /
>      bad OPP table size)
>   3) DVFS index used as clock rate without an upper bound check
>   4) scpi-cpufreq registered once only, and cleared on register failure
>      so remove() does not unregister an ERR_PTR
>   5) use PLATFORM_DEVID_NONE instead of bare -1 for the scpi-cpufreq
>      platform device id (readability; Fixes the original registration)
> 
> [...]

Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!

[1/5] firmware: arm_scpi: fix device_node leak in scpi_dev_domain_id
      https://git.kernel.org/sudeep.holla/c/65320b642025
[2/5] firmware: arm_scpi: reject DVFS OPP count above MAX_DVFS_OPPS
      https://git.kernel.org/sudeep.holla/c/32471d84a487
[3/5] clk: scpi: bound-check DVFS index in scpi_dvfs_recalc_rate
      https://git.kernel.org/sudeep.holla/c/70f4b78d560e
[4/5] clk: scpi: register scpi-cpufreq once and clear on failure
      https://git.kernel.org/sudeep.holla/c/ab06cf8152da
[5/5] clk: scpi: use PLATFORM_DEVID_NONE for scpi-cpufreq
      https://git.kernel.org/sudeep.holla/c/86d923a882f4
-- 
Regards,
Sudeep