[PATCH 1/2] staging: rtl8723bs: remove unused AMPDU burst mode
From: Adriano Cordova
Date: Fri Sep 04 2026 - 09:43:32 EST
AMPDUBurstMode is never written anywhere in the driver. HalData is
vzalloc'd, so the field is always 0, and the sole read in
_InitBurstPktLen_8723BS() is therefore always false. The only use of
REG_AMPDU_BURST_MODE_8723B is the guarded rtw_write8() that this
branch protects, so that register write never executes. Remove the
field, its enum and the dead branch.
Signed-off-by: Adriano Cordova <adrianox@xxxxxxxxx>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
drivers/staging/rtl8723bs/include/hal_data.h | 13 -------------
2 files changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 6a4a13544c..1389e5598d 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -868,8 +868,6 @@ void _InitBurstPktLen_8723BS(struct adapter *Adapter)
rtw_write8(Adapter, REG_MAX_AGGR_NUM_8723B, 0x1F);
rtw_write8(Adapter, REG_PIFS_8723B, 0x00);
rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_TXQ_CTRL)&(~BIT(7)));
- if (pHalData->AMPDUBurstMode)
- rtw_write8(Adapter, REG_AMPDU_BURST_MODE_8723B, 0x5F);
rtw_write8(Adapter, REG_AMPDU_MAX_TIME_8723B, 0x70);
/* ARFB table 9 for 11ac 5G 2SS */
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 57a18da67f..614fd88545 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -12,17 +12,6 @@
#include <hal_sdio.h>
-enum rt_ampdu_burst {
- RT_AMPDU_BURST_NONE = 0,
- RT_AMPDU_BURST_92D = 1,
- RT_AMPDU_BURST_88E = 2,
- RT_AMPDU_BURST_8812_4 = 3,
- RT_AMPDU_BURST_8812_8 = 4,
- RT_AMPDU_BURST_8812_12 = 5,
- RT_AMPDU_BURST_8812_15 = 6,
- RT_AMPDU_BURST_8723B = 7,
-};
-
#define CHANNEL_MAX_NUMBER (14) /* 14 is the max channel number */
#define CHANNEL_MAX_NUMBER_2G 14
#define MAX_PG_GROUP 13
@@ -240,8 +229,6 @@ struct hal_com_data {
/* Auto FSM to Turn On, include clock, isolation, power control for MAC only */
u8 bMacPwrCtrlOn;
- enum rt_ampdu_burst AMPDUBurstMode; /* 92C maybe not use, but for compile successfully */
-
u32 sdio_himr;
u32 sdio_hisr;
--
2.51.0