Re: [PATCH net-next v5 3/6] net: dsa: motorcomm: relocate MIB polling initialization to dsa_setup()

From: Andrew Lunn

Date: Fri Sep 04 2026 - 10:33:46 EST


On Fri, Sep 04, 2026 at 05:54:13PM +0800, Kyle Switch wrote:
> Move MIB polling start from probe() to dsa_setup()

Actually, having thread the following patches...

For every start, there is generally a stop.

You move start from probe() to dsa_setup().

Should you not move stop from remove() to dsa_teardown()?
You want to keep the driver symmetrical.

Andrew