[PATCH v3 13/17] media: fintek-cir: Remove unused fields

From: Sean Young

Date: Fri Sep 04 2026 - 10:54:08 EST


Some of these fields are vestigal from transmit, which never worked.

Signed-off-by: Sean Young <sean@xxxxxxxx>
---
drivers/media/rc/fintek-cir.c | 13 -------------
drivers/media/rc/fintek-cir.h | 22 ----------------------
2 files changed, 35 deletions(-)

diff --git a/drivers/media/rc/fintek-cir.c b/drivers/media/rc/fintek-cir.c
index c196ee923ecd..d4368181fef6 100644
--- a/drivers/media/rc/fintek-cir.c
+++ b/drivers/media/rc/fintek-cir.c
@@ -140,17 +140,6 @@ static int fintek_hw_detect(struct fintek_dev *fintek)
ir_class = fintek_cir_reg_read(fintek, CIR_CR_CLASS);
fit_dbg("ir_class reg: 0x%02x", ir_class);

- switch (ir_class) {
- case CLASS_RX_2TX:
- case CLASS_RX_1TX:
- fintek->hw_tx_capable = true;
- break;
- case CLASS_RX_ONLY:
- default:
- fintek->hw_tx_capable = false;
- break;
- }
-
chip_major = fintek_cr_read(fintek, GCR_CHIP_ID_HI);
chip_minor = fintek_cr_read(fintek, GCR_CHIP_ID_LO);
chip = chip_major << 8 | chip_minor;
@@ -169,7 +158,6 @@ static int fintek_hw_detect(struct fintek_dev *fintek)
spin_lock_irqsave(&fintek->fintek_lock, flags);
fintek->chip_major = chip_major;
fintek->chip_minor = chip_minor;
- fintek->chip_vendor = vendor;

/*
* Newer reviews of this chipset uses port 8 instead of 5
@@ -496,7 +484,6 @@ static int fintek_probe(struct pnp_dev *pdev, const struct pnp_device_id *dev_id
spin_lock_init(&fintek->fintek_lock);

pnp_set_drvdata(pdev, fintek);
- fintek->pdev = pdev;

ret = fintek_hw_detect(fintek);
if (ret)
diff --git a/drivers/media/rc/fintek-cir.h b/drivers/media/rc/fintek-cir.h
index 20696359e9ba..9ade9d7e7bfb 100644
--- a/drivers/media/rc/fintek-cir.h
+++ b/drivers/media/rc/fintek-cir.h
@@ -40,11 +40,9 @@ static int debug;
KBUILD_MODNAME ": " text "\n" , ## __VA_ARGS__)


-#define TX_BUF_LEN 256
#define RX_BUF_LEN 32

struct fintek_dev {
- struct pnp_dev *pdev;
struct rc_dev *rdev;

spinlock_t fintek_lock;
@@ -53,14 +51,6 @@ struct fintek_dev {
u8 buf[RX_BUF_LEN];
unsigned int pkts;

- struct {
- spinlock_t lock;
- u8 buf[TX_BUF_LEN];
- unsigned int buf_count;
- unsigned int cur_buf_num;
- wait_queue_head_t queue;
- } tx;
-
/* Config register index/data port pair */
u32 cr_ip;
u32 cr_dp;
@@ -73,17 +63,8 @@ struct fintek_dev {
/* hardware id */
u8 chip_major;
u8 chip_minor;
- u16 chip_vendor;
u8 logical_dev_cir;

- /* hardware features */
- bool hw_learning_capable;
- bool hw_tx_capable;
-
- /* rx settings */
- bool learning_enabled;
- bool carrier_detect_enabled;
-
enum {
CMD_HEADER = 0,
SUBCMD,
@@ -92,9 +73,6 @@ struct fintek_dev {
} parser_state;

u8 cmd, rem;
-
- /* carrier period = 1 / frequency */
- u32 carrier;
};

/* buffer packet constants, largely identical to mceusb.c */
--
2.55.0