Re: [RFC PATCH 2/3] powerpc: add support for Kexec HandOver (KHO)
From: Sourabh Jain
Date: Fri Sep 04 2026 - 11:57:39 EST
On 02/09/26 16:04, Pratyush Yadav wrote:
On Sun, Aug 23 2026, Sourabh Jain wrote:
On 21/08/26 17:26, Pratyush Yadav wrote:That calculation looks off. It _should_ be 200% once not twice. So 128
On Fri, Aug 21 2026, Sourabh Jain wrote:I agree that this is one way to work around the low-memory reservation problem.
Add the architecture bits needed to enable CONFIG_KEXEC_HANDOVER oncrashkernel has the variant "crashkernel=size[KMG],high", which ensures
powerpc.
Set ARCH_SUPPORTS_KEXEC_HANDOVER for PPC64, following the existing
pattern used by ARCH_SUPPORTS_KEXEC and ARCH_SUPPORTS_KEXEC_FILE.
On the boot path, parse the "linux,kho-fdt" and "linux,kho-scratch"
properties from /chosen and pass them to kho_populate(). This lets a
kernel booted via KHO kexec recover the FDT and scratch region left
behind by the previous kernel. The call is placed early in
setup_arch(), before unflatten_device_tree().
Open issues:
============
This patch also adds "depends on !CRASH_DUMP" to
ARCH_SUPPORTS_KEXEC_HANDOVER. This is needed because of an ordering
conflict between crashkernel reservation and KHO scratch reservation
on powerpc.
Crashkernel memory is reserved very early in boot, from arch-specific
code: head.S -> early_setup() -> early_init_devtree() ->
arch_reserve_crashkernel() / fadump_reserve_mem(). KHO's scratch
region is reserved later, from generic code: start_kernel() ->
mm_core_init() -> kho_memory_init(). So on powerpc, crashkernel
memory is always reserved first.
This ordering causes a real failure. In the common case, crashkernel
reservation on powerpc starts at a 512M offset (the exact offset can
vary, but 512M is typical). So with crashkernel=3G, the reservation
occupies memory from 512M up to 3.5G -- roughly 75% of the entire low
4G area.
Since crashkernel reservation always happens first, that 3G is
already committed by the time kho_memory_init() runs. It then tries
to reserve a low scratch region sized at 200% of whatever is already
reserved below 4G. With ~75% of that 4G area already taken by
crashkernel memory, 200% of that easily exceeds the remaining space
-- and since the low scratch region is itself capped at 4G, there's
no room left to fit it. The reservation fails.
memory is allocated above 4G. Unless powerpc has some requirement for
strictly having the crashkernel below 4G, I think it will make a lot of
sense to enable support for this feature. So KHO users can specify this
to get crashkernel working with KHO.
However, there are a few things that come into play here:
1. On powerpc, the crashkernel reservation can go up to 64 GB for kdump. With
the
current default scratch memory reservation policy, this could result in
reserving
up to 256 GB of scratch memory: 200% for the high-memory reservation and
another
200% for per-node memory.
GB total. If the allocation came out via the global area, it should
_only_ be accounted to the global scratch size. Similarly, only the
allocations made specifically on that node should be counted for the
per-node scratch size.
For example, if a system has only one node and 64 GB is allocated from
that node before the kernel starts calculating the per-node and global
allocations for scratch memory, wouldn't the per-node allocation also be 64 GB?
If so, wouldn't that result in 200% of 64 GB being allocated for the global
area and another 200% of 64 GB for the per-node area, resulting in 256 GB
of total scratch memory allocation? Or am I missing something here?
But I have also noticed this problem on some of the systems Google has.
Which makes me wonder if scratch_size_update() is broken and
over-calculating. I have this on my TODO list and have been meaning to
look into it, but other things keep intervening.
If you are interested, feel free to take it off my hands.
Yes, I can take this up and propose patches to make crashkernel and
scratch reservations work together.
Based on my current testing, a Linux partition (powerpc) with 16 CPUs and 30 GB
of RAM needs only 16 MB of scratch memory in the low-memory area when
crashkernel=xxM is not specified.
16 MB is not much. I am also trying to get a larger Linux partition with 1000+
CPUs to get a better idea of the limits for low-memory reservations.
BTW, do you know the rationale behind the 200% value?
I couldn't find any explanation for it in the commit message of
3dc92c311498c ("kexec: add Kexec HandOver (KHO) generation helpers")
For fadump, which is the powerpc-specific memory dump capture mechanism, theOnce we fix scratch_size_update() to actually use 200% and not 400%,
crashkernel
reservation can go up to 180 GB. In this case, we could end up reserving up
to 720 GB of
scratch memory, which is too much. I agree that users can tune this, but I
think the
default scale should be more reasonable for powerpc.
perhaps that alone will be enough? If not, we can discuss reducing the
default scratch scale to maybe 150%. But I'd rather do it for all
platforms if we do it at all, because this problem doesn't seem specific
to PowerPC.
Yes, it makes sense to have a general fix that works for all architectures.
BTW, I was able to reproduce this issue on x86 as well. Please have a
look at this:
https://lore.kernel.org/all/008fe00e-fd52-4010-86ca-f0ab80a65a46@xxxxxxxxxxxxx/ <https://lore.kernel.org/all/008fe00e-fd52-4010-86ca-f0ab80a65a46@xxxxxxxxxxxxx/>
I have also suggested an approach to handle this issue which is similar how you handle
huge pages. Please share your thoughts on it.
Oh, nice!
2. Fadump also uses the crashkernel kernel command-line argument, but its
reservation policy
is different from kdump. The crashkernel base address starts after the memory
needed for
fadump. For example, with crashkernel=3G, the base address would be 3 GB, and
the crashkernel
reservation would be from 3 GB to 6 GB. So, depending on the crashkernel
size, the reservation
may or may not fall within low memory. Also, fadump does not support
crashkernel=xxM,high.
3. I do have a patch [1] to support high crashkernel reservations with kdump,
but this would not
work with Hash MMU. With Hash MMU, the kernel image is constrained to low
memory, whereas with
crashkernel=,high, all segments would be loaded into high memory.
So, while supporting crashkernel=,high can help address the low-memoryThe problem today is that kho_preserved_memory_reserve() (called by
reservation issue for kdump,
I think there are still some powerpc-specific constraints to consider. I would
like to explore
whether we can fix the ordering between crashkernel and scratch memory
reservations, so that we can
avoid unnecessarily large scratch memory reservations and address some of the
other constraints mentioned
above. Please share your thoughts.
Powerpc doesn't support this right now, but from a quick skim of theI have patch series under review for the same:
code, I think it should be simple enough.
[1]
https://lore.kernel.org/all/20260708143357.673251-1-sourabhjain@xxxxxxxxxxxxx/
FromDue to some architecture-specific dependencies (such as RTAS), booting the
arch_reserve_crashkernel() you just need to pass a bool * to
parse_crashkernel(), and then pass the result to
reserve_crashkernel_generic().
kernel from above 4G with
support for high crashkernel is not as straightforward as on other
architectures. Patch 2/4 in [1] has the
details.
Solving the ordering of crash reservations and KHO is tricky and comes
with some difficult tradeoffs. Allocating crash from highmem should be a
lot simpler.
Could you please elaborate a bit on what makes the ordering tricky and what the
main tradeoffs are between crash reservations and KHO? It would help me better
understand the concerns here.
kho_mem_retrieve()) does a memblock_reserve() for each preserved folio.
So if you have a lot of order-0 (or, 4k) folios, you end up with a lot
of reservations in memblock. The large number of reservations can slow
down later memblock operations like allocations too since memblock might
have to walk through a lot of ranges to find free memory.
We kind of work around this problem by calling kho_mem_retrieve() as
pretty much the last thing in the MM init. So all allocations prior to
this have already been fulfilled from scratch without any of the
reservations added, so it should be pretty fast. You only take the
performance hit at the end, where the only thing left is to release
pages to buddy.
Ah, okay, that makes sense. Thanks for the clarification.
Even then, the memblock reservations can get pretty damn slow. In some
of my testing with under-load systems, preserving a 2G memfd with 4k
pages can go over **5 minutes** in only kho_mem_retrieve() if the folios
of the memfd are fragmented enough. Plus there is the memory overhead of
the regions in memblock.reserved.
5 minutes in kho_mem_retrieve(), which is primarily marking a bunch
of memory as reserved using memblock, seems like quite a lot. If you
have the test case handy somewhere, I would be interested in trying it
myself, just to get a better feel for the issue.
Regardless, I understand the concern now. From my perspective also, the
current ordering of crashkernel and scratch memory reservations seems
reasonable, because crashkernel is not as flexible as scratch reservation
atleast on powerpc.
On powerpc, the crashkernel offset is determined first, and the
corresponding memory region is reserved. To make sure that no
other reservation falls within the crashkernel region, the crashkernel
reservation is one of the first reservations we make on powerpc.
If we change this ordering, there is a possibility that a scratch
reservation could end up in a region where the crashkernel is supposed
to be placed. That would lead to crashkernel reservation failure.
Also, reserving scratch memory at a location where the crashkernel
cannot be placed could be problematic. Each architecture has its own
constraints on where the crashkernel can be placed, so the available
memory for scratch reservation may need to account for those constraints.
Which I think too much to take care off...
And, of course, moving kho_mem_retrieve()earlier during boot would
also mean taking the performance hit you mentioned earlier.
So let's keep the current ordering and find a way to make both
reservations work with it: reserve the crashkernel first, and then
reserve the scratch memory.
So long-term, I would like to get rid of the memblock reservations
entirely and use scratch-only mode all the way until buddy comes up. And
I would like to modify buddy init (free_low_memory_core_early() and
deferred_init_memmap_chunk()) to be KHO-aware and directly skip the KHO
pages.
This vision goes in the opposite direction of turning scratch-only mode
off _earlier_. And turning off scratch-only mode earlier is necessary
for doing crash reservations outside of scratch.
That is the tradeoff I mentioned. Hope I was clear enough.
Yes, that makes sense. I understand the tradeoff you're pointing out
now.
My point is that !CRASH_DUMP can be removed _even if_ we don't settleAnd on that note, I don't think you should do a depends on !CRASH_DUMP.Agree. depends on !CRASH_DUMP is temporary and will be removed once
Even when CONFIG_KEXEC_HANDOVER is enabled, KHO isn't on by default
(well, unless KEXEC_HANDOVER_ENABLE_DEFAULT is set). You need to enable
it via cmdline. So it is entirely possible for people using KHO on PPC
to not use crash and vice versa. This decision can be made at deployment
time, not at compile time.
we settle the crashkernel reservation and scratch region handling.
the reservation thing, because it is perfectly valid for the same kernel
to use either KHO or crash but not at the same time. These both can be
enabled/disabled at runtime.
Agree I will drop the !CRASH_DUMP dependency...
- Sourabh Jain