Re: [PATCH v7 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller

[Marek Vasut]

On 9/4/26 5:32 PM, Conor Dooley wrote:

Hello Conor,

[...]

> > +required:
> > +  - compatible
> > +  - reg
> > +  - reg-names
> > +  - clocks
> > +  - interrupts
> > +  - phys
> > +  - phy-names
> > +  - power-domains
> > +  - resets
> > +
> > +unevaluatedProperties: false
>
> I said this elsewhere today, but this binding has lots of "distasteful"
> properties for things that should be determined from the compatible

Which properties would those be ? (it seems 
reg/clocks/interrupts/phys/power-domains/resets really need to be there 
as separate properties, but maybe I am missing the point?)

> , so I
> would appreciate it if you could use additionalProperties: false here
> cite the ones you need to use explicitly.

May I ask, what exactly is the rule of thumb for 
additionalProperties:false and unevaluatedProperties:false ? I seem to 
struggle with picking the right one for a while now.

> Sounds like dr_mode: true and
> maximum-speed: true are all you'd need?
Ah, I think this also answers my previous question a bit. And, as for 
limiting the properties that are really needed -- this pulls in the 
common DWC3 USB IP core properties, which all do apply to the DWC3 core. 
They might not be used on current hardware, but they are still valid for 
the DWC3 core (IP).

Thank you for your help !