Re: [PATCH v3 2/2] arm64: dts: ti: Add support for the phyCORE-AM62Px

[Nishanth Menon]

On 11:37-20260810, John Ma wrote:
> Add support for the PHYTEC phyCORE-AM62Px SoM [1] and the
> corresponding phyBOARD-Lynx carrier board [2]. The phyCORE-AM62Px SoM
> uses the TI AM62Px SoC and can come with different sizes and models of
> DDR, eMMC, and SPI NOR Flash.
> 
> Supported features:
>   * Audio playback and recording
>   * CAN
>   * Debug UART
>   * eMMC
>   * Ethernet
>   * GPIO buttons
>   * Heartbeat LED
>   * I2C EEPROM
>   * I2C RTC
>   * Micro SD card
>   * SPI NOR flash
>   * SPI Accelerometer
>   * USB
> 
> [1] https://www.phytec.com/product/phycore-am62px/
> [2] https://www.phytec.com/product/phyboard-am62px-development-kit/
> 
> Test results:
> https://gist.github.com/jma-phytec/fd7911a834e39b3fac0104690668882e
> 
> Signed-off-by: John Ma <jma@xxxxxxxxxx>
> Reviewed-by: Wadim Egorov <w.egorov@xxxxxxxxx>
> ---
> v3:
>   - update EXTINTn pimmux
>   - fixed tab/space issue
>   - update interrupt for pmic
> v2:
>   - added bootph-all in cpsw3g_phy1 node
>   - fixed ti,fifo-depth property deprecated issue
>   - update ospi vcc-supply label from SoM
>   - added bootph-all in wkup_i2c0 node
>   - sorted nodes in alphabetical order
>   - sorted vendor property
>   - removed unsed leds from phyboard lynx dts
>   - added chosen/stdout-path
>   - update usb0_connector node with proper name
>   - fixed missing space
>   - removed unused pinmux
>   - removed bootph-all from rgmii2 pinmux
>   - added interrupt-names for adxl345 node
>   - sorted status property in main_uart1
> 
>  arch/arm64/boot/dts/ti/Makefile               |   1 +
>  .../boot/dts/ti/k3-am62p-phycore-som.dtsi     | 340 ++++++++++++
>  .../boot/dts/ti/k3-am62p5-phyboard-lynx.dts   | 522 ++++++++++++++++++
>  3 files changed, 863 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi
>  create mode 100644 arch/arm64/boot/dts/ti/k3-am62p5-phyboard-lynx.dts
> 
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 371f9a043fe5..b223681cdfbf 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -76,6 +76,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62d2-evm.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am62l3-evm.dtb
>  
>  # Boards with AM62Px SoC
> +dtb-$(CONFIG_ARCH_K3) += k3-am62p5-phyboard-lynx.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am62p5-var-som-symphony.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-am62p5-verdin-nonwifi-dahlia.dtb
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi
> new file mode 100644
> index 000000000000..0e3a429a835d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-phycore-som.dtsi
> @@ -0,0 +1,340 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/*
> + * Copyright (C) 2026 PHYTEC America LLC
> + * Author: John Ma <jma@xxxxxxxxxx>
> + *
> + */

Could you do a couple of things:
a) rebase this to latest next.
b) ./scripts/dtc/dt-check-style --mode=strict new_files

I know that --mode=strict is not perfect at this point, but, it
did point me a few issues in status ordering, bootph ordering
consistency etc.. you will have to (at this point) cross verify
against ./Documentation/devicetree/bindings/dts-coding-style.rst

Example:
arch/arm64/boot/dts/ti/k3-am62p5-phyboard-lynx.dts:315: [required-blank-lines] "status" must be preceded by a blank line


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource