Re: [PATCH v10 1/2] rust: Add dma_fence abstractions

[Philipp Stanner]

On Fri, 2026-09-04 at 17:32 +0200, Danilo Krummrich wrote:
> On Wed Aug 12, 2026 at 9:22 AM CEST, Philipp Stanner wrote:
> > Add abstractions for dma_fence in Rust.
> 
> I was about to pick this up, but ended up with too many things to tweak.

:(

> 
>   * Fix checkpatch.pl warnings,

I get two, one of them being obsolete

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#114: 
new file mode 100644

WARNING: line length of 101 exceeds 100 columns
#158: FILE: rust/helpers/dma_fence.c:40:
+__rust_helper void rust_helper_dma_fence_unlock_irqrestore(struct dma_fence *f, unsigned long *flags)


> 
>   * use Opaque::zeroed() instead of __GFP_ZERO,

That's literally what I had originally, but Alice objected and wanted
GFP_ZERO, AFAIR because it's more efficient.

Maybe you two want to get to an agreement on what's better.

>   * use kernel vertical import style.
> Here's the diff I suggest for a v11:

Thx, I'll take it into account.



P.