Re: [PATCH v10 1/7] firmware: smccc: Add an Arm SMCCC bus

[Jason Gunthorpe]

> [ ... 243 lines skipped ... ]
> +++ b/include/linux/device-id/arm_smccc.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __LINUX_DEVICE_ID_ARM_SMCCC_H
> +#define __LINUX_DEVICE_ID_ARM_SMCCC_H
> +
> +#define ARM_SMCCC_MODULE_PREFIX "arm_smccc:"
> +
> +/**
> + * struct arm_smccc_device_id - Arm SMCCC bus device identifier
> + * @func_id: SMCCC function identifier
> + */
> +struct arm_smccc_device_id {
> +	__u32 func_id;

 [Severity: Low]
 Does this new header need to include <linux/types.h> so that it is
 self-contained? 

 If a C file includes <linux/device-id/arm_smccc.h> directly without a prior 
 inclusion of <linux/types.h>, the __u32 type used in arm_smccc_device_id will 
 be undeclared, which will cause a compilation failure.

It is minor, but if you have to respin it is nice for clangd users if
headers are self contained.

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

-- 
Jason