Re: [PATCH v6 11/13] serial: 8250_dw: add Ambarella CV75 quirks
From: Linus Walleij
Date: Fri Sep 04 2026 - 18:43:20 EST
On Fri, Sep 4, 2026 at 8:39 AM Long Zhao via B4 Relay
<devnull+longzhao.ambarella.com@xxxxxxxxxx> wrote:
> From: Long Zhao <longzhao@xxxxxxxxxxxxx>
>
> The Ambarella CV75 UART is Ambarella IP, not a Synopsys DesignWare
> licensed block. At the register level it is close enough to DW APB UART
> that a full custom UART driver is unnecessary: reuse 8250_dw with a
> small platform quirk.
>
> Quirks:
> - keep IER ETOI (bit 5) set for RX timeout behaviour
> - skip set_rate; baud clock is managed outside the UART block
>
> Signed-off-by: Long Zhao <longzhao@xxxxxxxxxxxxx>
This is really nice. Compare the size of this to what was initially
submitted!
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
Yours,
Linus Walleij