Re: [PATCH 1/2] Input: tca8418_keypad - Add devm cleanup to disable interrupts on unload

Next message: mdshahid03: "[PATCH v3 3/6] iio: adc: bcm_iproc_adc: use devm-managed clock"
Previous message: mdshahid03: "[PATCH v3 2/6] iio: adc: bcm_iproc_adc: fix include dependencies"
In reply to: Zhian Liang: "[PATCH v2] Input: tca8418_keypad - Add devm cleanup to disable interrupts on unload"
Next in thread: Zhian Liang: "Re: [PATCH 1/2] Input: tca8418_keypad - Add devm cleanup to disable interrupts on unload"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Dmitry Torokhov

Date: Sat Sep 05 2026 - 05:37:58 EST

Hi Zhian,

On Fri, Sep 04, 2026 at 03:29:41AM +0800, Zhian Liang wrote:
> tca8418_configure() enables TCA8418 interrupts by writing the CFG
> register. If input_register_device() fails afterwards, probe returns
> an error and devres releases the IRQ handler, but the hardware is
> left with interrupts still enabled.

What kind of issues does it cause?

Thanks.

--
Dmitry