Re: [net,PATCH v1] net: ks8851: Fix receiver error in 100BASE-TX mode following software power-down

[Marek Vasut]

On 9/5/26 3:28 AM, Jakub Kicinski wrote:
> On Sat, 5 Sep 2026 03:16:12 +0200 Marek Vasut wrote:
> > On 9/4/26 2:37 AM, Jakub Kicinski wrote:
> > > This is an AI-generated review of your patch.
> >
> > Sigh, a wall of generated text.
>
> I'd feel bad if most of the patches I have to suffer thru
> these days weren't entirely YOLO'ed slop where every lines comes
> with a 15 line comment :/ (not speaking about your patch, just
> a general vent)

I do understand.

This happens in other areas/projects too, although it seems netdev is 
really pummeled by this.

> > > > @@ -506,8 +503,6 @@ static int ks8851_net_stop(struct net_device *dev)
> > > >    	/* shutdown TX process */
> > > >    	ks8851_wrreg16(ks, KS_TXCR, 0x0000);
> > > >    
> > > > -	/* set powermode to soft power down to save power */
> > > > -	ks8851_set_powermode(ks, PMECR_PM_SOFTDOWN);
> > > >    	ks8851_unlock(ks);
> > >
> > > [Severity: Low]
> > > Related to the above: the kernel-doc for ks8851_net_stop() just above this
> > > function still promises the low power transition that is being removed here:
> > >
> > > 	/**
> > > 	 * ks8851_net_stop - close network device
> > > 	 * @dev: The device being closed.
> > > 	 *
> > > 	 * Called to close down a network device which has been active. Cancel any
>                                                  vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> > > 	 * work, shutdown the RX and TX process and then place the chip into a low
>             vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvXXXX^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > 	 * power state whilst it is not being used.\
>             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > 	 */
> > >
> > > The post-patch body only masks IER/ISR, zeroes RXCR1/TXCR, drains ks->txq
> > > and calls free_irq(), with no PMECR access left. Should that last sentence
> > > be dropped or reworded to mention the errata, so readers of
> > > ks8851_suspend()->ks8851_net_stop() are not told a low power transition
> > > happens?
> >
> > What exactly should I adjust in V2 ?
>
> Drop the part of the sentence in the ks8851_net_stop() kdoc that says
> we'll put the device in low power mode?

I will do so in V2. I appreciate the human feedback. Thank you.