Re: [PATCH] gpu: nova-core: gsp: fix a broken doc link on GspMessage

From: John Hubbard

Date: Sat Sep 05 2026 - 13:23:44 EST


On 9/5/26 7:25 AM, Gary Guo wrote:
On Sat Sep 5, 2026 at 3:38 AM BST, John Hubbard wrote:
The doc comment on the GSP message type names Cmdq as the type that
defines wait_for_msg. That method belongs to CmdqInner, so the link has
no target. Nothing catches the break, because rustdoc resolves a link
only in an item it documents, and the kernel's rustdoc run skips private
items.

Point the link at CmdqInner.

Assisted-by: Cursor:claude-opus-5

nit: kernel policy has changed and this should just say "Assisted-by: LLM" now.

So it has! Perhaps Danilo or Alex can change that for me upon applying
this, to save a re-spin.


Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>

Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>


thanks,
--
John Hubbard