Re: [PATCH] virtio_console: Fix alloc_buf(.gfp) usage

From: Greg Kroah-Hartman

Date: Sat Sep 05 2026 - 13:33:51 EST


On Fri, Aug 28, 2026 at 05:37:06PM +0200, Peter Zijlstra wrote:
>
> Commit fc220d6be3c7 ("virtio_console: refactor __send_to_port() buffer
> ownership") added a .gfp argument to alloc_buf(), but forgot to convert
> all allocation calls.
>
> The result is that any GFP_ATOMIC calls, such as those from:
>
> hvc_console_print()
> put_chars()
> alloc_buf(.gfp = GFP_ATOMIC)
>
> will trip the might_sleep_if() check when used from an atomic context.
>
> Fixes: fc220d6be3c7 ("virtio_console: refactor __send_to_port() buffer
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> ---
>

Sorry for the delay, I took this earlier patch instead:
https://lore.kernel.org/r/20260810-serial-v1-1-abbe51602c13@xxxxxxxxxx