Re: [PATCH] iio: cdc: ad7150: fix OF matching and publish module aliases

[Jonathan Cameron]

On Sat,  5 Sep 2026 21:39:39 +0800
"hpp.iscas" <hppiscas@xxxxxxx> wrote:

> The positional initializers in ad7150_of_match populate the name member
> of struct of_device_id, not compatible. Consequently the table does not
> match the compatible properties documented for AD7150, AD7151 and AD7156.
> The table is also absent from the module alias metadata.
> 
> Use designated compatible initializers and publish the corrected table.
> Keep the existing I2C ID fallback and per-device driver data unchanged.
> 
> Fixes: 89f2d5b080bc ("staging:iio:cdc:ad7150: Add of_match_table")
> Signed-off-by: hpp.iscas <hppiscas@xxxxxxx>
Hi, 

We need a 'known' identifier for signed off. That basically means
real name or a name that you have used widely in other forums.
I did my usual test of putting hpp.iscas into google and seeing if 
anything looked like a person in the top few links.

As nothing does, I can't pick this up under the Developer Certificate
of Origin (look in docs if this not familiar to you) rules.

Please either provide me with some links as evidence this is a well
known identifier for you, or send a v2 with a name.

Patch itself is good.

thanks,

Jonathan


> ---
>  drivers/iio/cdc/ad7150.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/cdc/ad7150.c b/drivers/iio/cdc/ad7150.c
> index 2f35c6d..b36ac4e 100644
> --- a/drivers/iio/cdc/ad7150.c
> +++ b/drivers/iio/cdc/ad7150.c
> @@ -636,11 +636,13 @@ static const struct i2c_device_id ad7150_id[] = {
>  MODULE_DEVICE_TABLE(i2c, ad7150_id);
>  
>  static const struct of_device_id ad7150_of_match[] = {
> -	{ "adi,ad7150" },
> -	{ "adi,ad7151" },
> -	{ "adi,ad7156" },
> +	{ .compatible = "adi,ad7150" },
> +	{ .compatible = "adi,ad7151" },
> +	{ .compatible = "adi,ad7156" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, ad7150_of_match);
> +
>  static struct i2c_driver ad7150_driver = {
>  	.driver = {
>  		.name = "ad7150",
>