Re: [PATCH net-next v5 3/6] net: dsa: motorcomm: relocate MIB polling initialization to dsa_setup()

[Kyle Switch]

On 9/4/26 21:37, Andrew Lunn wrote:
> On Fri, Sep 04, 2026 at 05:54:13PM +0800, Kyle Switch wrote:
> > Move MIB polling start from probe() to dsa_setup() so that it can
> > be conditionally enabled based on the actual switch family support,
> > avoiding attempts to enable it on unsupported switch families.
> >
> > Signed-off-by: Kyle Switch <kyle.switch@xxxxxxxxxxxxxx>
> Much better.
>
> I would word the commit message slightly differently, in order to make
> it clear what this patch does vs a future patch.
>
>    > Move MIB polling start from probe() to dsa_setup() so that in a
>    > future patch it can be conditionally enabled based on the actual
>    > switch family support, avoiding attempts to enable it on
>    > unsupported switch families.
>
> What you want to avoid is my asking, did you forget to make it
> conditional?

Ans: okay,we will improve the commit message and keep this

in mind for future patch submissions.

> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
>      Andrew