[PATCH 1/9] ASoC: nau8821: stop resume when cache sync fails

[Pengpeng Hou]

nau8821_resume() restores cached registers during component resume but
ignores a regcache_sync() failure and continues with IRQ enablement.
Those operations assume that the codec register state has already been
restored.

Stop the local resume sequence when cache replay fails and return the
error to the ASoC component wrapper. The wrapper reports the failure
while retaining best-effort card resume, so no rollback or retry
semantics are introduced.

The issue was found by our static-analysis tool and manually reviewed.

Fixes: aab1ad11d69f ("ASoC: nau8821: new driver")
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <hppiscas@xxxxxxx>
---
 sound/soc/codecs/nau8821.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c
index c45c5b864ea4..c79be1c07f66 100644
--- a/sound/soc/codecs/nau8821.c
+++ b/sound/soc/codecs/nau8821.c
@@ -1628,9 +1628,13 @@ static int __maybe_unused nau8821_suspend(struct snd_soc_component *component)
 static int __maybe_unused nau8821_resume(struct snd_soc_component *component)
 {
 	struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+	int ret;
 
 	regcache_cache_only(nau8821->regmap, false);
-	regcache_sync(nau8821->regmap);
+	ret = regcache_sync(nau8821->regmap);
+	if (ret)
+		return ret;
+
 	if (nau8821->irq)
 		enable_irq(nau8821->irq);
 
-- 
2.50.1 (Apple Git-155)