Re: [PATCH v4 4/4] arm64: dts: cix: Add USB4/USB5 nodes for Sky1

[Krzysztof Kozlowski]

On 06/09/2026 05:24, Hongliang Yang wrote:
> Add USB4 and USB5 controller nodes for the CIX Sky1 SoC. Enable USB4
> and USB5 in host mode on the Radxa Orion O6 board.
> 
> The per-controller RCSU registers are accessed through a syscon regmap
> referenced by the cix,usb-rcsu phandle.
> 
> The shared RCSU slice of the two controllers is described by a syscon
> node; each controller references its registers through the cix,usb-rcsu
> phandle with offsets.
> Signed-off-by: Hongliang Yang <hongliang.yang@xxxxxxxxxxx>


Odd style. Please read `git commit` help page to understand how to add
the tag properly.

> ---
>  arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 42 +++++++++++
>  arch/arm64/boot/dts/cix/sky1.dtsi         | 88 +++++++++++++++++++++++
>  2 files changed, 130 insertions(+)

For the last time, read my v2 feedback

Which subsystems do you target here?

Which subsystems do you target in the previous patch?

Why are you combining them, even though I asked not?

Best regards,
Krzysztof