Re: [PATCH 1/8] i2c: omap: Drop bit shift for I2C register addresses

[Andreas Kemnade]

On Fri, 4 Sep 2026 08:12:45 -0500
Andrew Davis <afd@xxxxxx> wrote:

> No remaining board device uses a shift other than 2, and no DT supported
> platform ever did. We can drop this flag and use the pre-shifted register
> addresses. This simplifies the register access.
> 
> Signed-off-by: Andrew Davis <afd@xxxxxx>
> ---
>  arch/arm/mach-omap1/i2c.c              |  4 ---
>  drivers/i2c/busses/i2c-omap.c          | 50 +++++++++++---------------
>  include/linux/platform_data/i2c-omap.h |  5 ---
>  3 files changed, 21 insertions(+), 38 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/i2c.c b/arch/arm/mach-omap1/i2c.c
> index 94d3e7883e027..bc7828a858941 100644
> --- a/arch/arm/mach-omap1/i2c.c
> +++ b/arch/arm/mach-omap1/i2c.c
> @@ -61,10 +61,6 @@ int __init omap_i2c_add_bus(struct omap_i2c_bus_platform_data *pdata,
>  		       OMAP_I2C_FLAG_16BIT_DATA_REG |
>  		       OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK;
>  
> -	/* how the cpu bus is wired up differs for 7xx only */
> -
This could perhaps go into the commit message, but besides of that
Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>