Re: [PATCH v4 0/2] staging: iio: adc: ad7816: Fix SPI read operations and VMAP_STACK issue

[Joshua Crofts]

On Sun,  6 Sep 2026 14:40:47 +0300
Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx> wrote:

No overall description of what the patch series actually does?

> Changes in v4:
> - Separated changes into two logical patches.
> - Patch 1: Used guard(mutex) and devm_mutex_init() instead of manual lock/unlock and mutex_init().
> - Patch 2: Used __aligned(IIO_DMA_MINALIGN) instead of ____cacheline_aligned.
> - Patch 2: Fixed the sizeof() argument in spi_read().

I assume you forgot to send this patch? It's not listed below...

Either way, NACK to this series until all of the patches do exactly
what their commit messages say. Applying patch 1 causes compiler
errors. Ideally, you should compile each patch separately to prevent this.

> Abdelnasser Hussein (2):
>   staging: iio: adc: ad7816: Serialize SPI read operations
>   staging: iio: adc: ad7816: Use DMA-safe buffer for SPI read
> 
>  drivers/staging/iio/adc/ad7816.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> 
> base-commit: 3d6d817622b0a9721e3cc404df3469171582be13



-- 
Kind regards,
Joshua Crofts