Re: [PATCH 7/7] KVM: selftests: Skip xAPIC IPI migration test when forced but unsupported

[Garg, Shivank]

On Wed, 2026-09-02 at 17:16 -0700, Sean Christopherson wrote:
> Skip the xAPIC IPI migration test instead of failing outright if migration
> is forced by the user, but is unsupported due to lack of NUMA support.
> Failing the test is arguably "fine" for opt-in behavior, but in practice
> doesn't allow running the test in forced-migration mode in any kind of
> automated test environment.
> 
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> ---
>  tools/testing/selftests/kvm/x86/xapic_ipi_test.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/x86/xapic_ipi_test.c b/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
> index c5b506eb5e7f..2362bf272e80 100644
> --- a/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
> +++ b/tools/testing/selftests/kvm/x86/xapic_ipi_test.c
> @@ -469,8 +469,9 @@ int main(int argc, char *argv[])
>  	if (kvm_get_numa_memory_nodes(&nodemask) > 1)
>  		test_xapic_ipi(run_secs, delay_usecs, true);
>  	else
> -		TEST_ASSERT(!force_migrate,
> -			    "Did not find at least 2 numa nodes. Can't do migration");
> +		__TEST_REQUIRE(!force_migrate,
> +			       "Need at least 2 NUMA nodes to do migration (nodemask = 0x%lx)",
> +			       nodemask);
>  
>  	return 0;
>  }


Reviewed-by: Shivank Garg <shivankg@xxxxxxx>

Thanks,
Shivank