Re: [PATCH net-next v5 1/6] net: dsa: motorcomm: refactor registration path for upcoming switch families
From: David Yang
Date: Sun Sep 06 2026 - 14:31:40 EST
On Sun, Sep 6, 2026 at 10:08 AM Kyle Switch <kyle.switch@xxxxxxxxxxxxxx> wrote:
> >> static const struct of_device_id yt921x_of_match[] = {
> >> - { .compatible = "motorcomm,yt9215" },
> >> - {}
> >> + {
> >> + .compatible = "motorcomm,yt9215",
> >> + .data = &yt92xx_series_info_table[YT921X],
> > Redundant if you use both runtime identification and the match data.
> > Also I'm concerned with early IO operations, although I didn't see any
> > incorrectness here.
>
> Ans: we have considered this issue before. in the next version, we
>
> will consider whether to do it via chip_detect() or using indexed
>
> assignment. From your suggestion, what are the side effects of each
>
> approach and which of the two approaches do you recommend?
We didn't use compat info since we can do all the probing after the
reset, but I think the compat info here is "just enough". You can
still change your mind in any series later.