Re: [PATCH v4 02/10] dt-bindings: iio: adc: support the TI ADS126x ADC family

[Kurt Borja]

On Mon Aug 31, 2026 at 4:44 PM -03, David Lechner wrote:
> On 8/28/26 1:38 AM, Kurt Borja wrote:
>> The ADS1262 and ADS1263 are 32-bit, 38.4-kSPS delta-sigma ADCs with an
>> integrated PGA, internal reference, excitation and burn-out current
>> sources for sensor biasing and diagnostics. The ADS1263 is compatible
>> with ADS1262, but includes a second auxiliary ADC (ADC2) to perform main
>> channel (ADC1) cross-checking measurements, system background
>> measurements, or temperature compensation of the primary sensor.
>> 
>
> ...
>
>> +  '#io-channel-cells':
>> +    minimum: 1
>> +    maximum: 2
>> +    description: |
>> +      The first cell selects the channel by its reg. The second cell selects
>> +      between the main ADC (ADC1) and the auxiliary ADC (ADC2) as follows:
>> +        0: ADC1
>> +        1: ADC2
>> +
>
> I like the suggestion to make this always 2 cells. Makes it simpler. And
> to put ADC first.
>
> And maybe make the first cell take 1, 2 so we don't have to make the
> translation?

Sure!

>
>
>
>> +  "^channel@[0-9a-f]+$":
>> +    $ref: /schemas/iio/adc/adc.yaml#
>> +    unevaluatedProperties: false
>> +
>
> ...
>
>> +allOf:
>> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: ti,ads1263
>> +    then:
>> +      properties:
>> +        '#io-channel-cells':
>> +          minimum: 1
>> +          maximum: 2
>> +      patternProperties:
>> +        "^channel@[0-9]+$":
>
> These don't match the pattern above (missing a-f).
>
>> +          properties:
>> +            reference-sources:
>> +              minItems: 3
>> +              maxItems: 3
>> +              default: [internal-p, internal-n, internal]
>> +    else:
>> +      properties:
>> +        '#io-channel-cells':
>> +          const: 1
>> +      patternProperties:
>> +        "^channel@[0-9]+$":
>> +          properties:
>> +            reference-sources:
>> +              minItems: 2
>> +              maxItems: 2
>> +              default: [internal-p, internal-n]
>> +
> With those fixed...
>
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>

Thanks David!

-- 
Thanks,
 ~ Kurt