RE: [PATCH rtw-next v8 2/3] wifi: rtw88: rtw8822c: Convert DAC IQ calibration path to signed math

From: Ping-Ke Shih

Date: Sun Sep 06 2026 - 21:11:35 EST


Arsenii Pashchenko <ulijg308@xxxxxxxxx> wrote:
> Convert the temporary stack arrays 'iv' and 'qv' from u32 to s32.
> Update all internal function signatures to accept s32 pointers and
> handle signed values natively.
>
> Use sign_extend32() combined with FIELD_GET_SIGNED() to properly interpret
> the 10-bit hardware values as signed integers. This allows flattening
> the complex nested unsigned boundary conditions in
> rtw8822c_dac_iq_check() into a simple amplitude boundary check. Ensure
> rtw8822c_dac_iq_offset() properly maps the signed average back to a
> 10-bit unsigned format expected by the hardware registers via GENMASK().
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>