Re: [PATCH v2 1/4] dt-bindings: phy: qcom: add Nord QMP PCIe PHY binding

[Qiang Yu]

On Mon, Aug 31, 2026 at 09:54:40AM +0200, Konrad Dybcio wrote:
> On 8/28/26 10:43 AM, Krishna Chaitanya Chundru wrote:
> > Document the PCIe PHY found on the Qualcomm Nord platform.
> > 
> > Nord has a Gen5-capable QMP PCIe PHY that can operate in multiple
> > lane configurations using four PHY segments (A/B/C/D). The active
> > topology is selected by firmware through a TCSR configuration
> > register and may be configured as x16, x8+x8, x8+x4+x4, or
> > x8+x4+x2+x2.
> > 
> > The binding describes the register regions, clocks, resets, power
> > domains, regulators, PHY provider interface, clock provider interface,
> > and the qcom,link-mode property used by the driver to discover the
> > active lane configuration programmed by firmware.
> > 
> > Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx>
> > ---
> >  .../phy/qcom,nord-qmp-gen5x16-pcie-phy.yaml        | 276 +++++++++++++++++++++
> >  1 file changed, 276 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,nord-qmp-gen5x16-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,nord-qmp-gen5x16-pcie-phy.yaml
> > new file mode 100644
> > index 000000000000..37198f82c611
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/qcom,nord-qmp-gen5x16-pcie-phy.yaml
> > @@ -0,0 +1,276 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/qcom,nord-qmp-gen5x16-pcie-phy.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Nord QMP Bifurcated PCIe PHY
> 
> Quadfurcated, perhaps? Is there a word in the spec that doesn't get too
> detailed about the number of effective slots that the PHY is divided into?
>

What about multiple link-mode PHY?

- Qiang Yu

> [...]
> 
> > +  vdda-phy-a-supply: true
> > +
> > +  vdda-phy-b-supply: true
> > +
> > +  vdda-phy-c-supply: true
> > +
> > +  vdda-phy-d-supply: true
> > +
> > +  vdda-pll-a-supply: true
> > +
> > +  vdda-pll-b-supply: true
> > +
> > +  vdda-pll-c-supply: true
> > +
> > +  vdda-pll-d-supply: true
> 
> I'm really surprised they aren't all connected to the same pair but oh well
> 
> Konrad
>