Re: [PATCH v3 15/19] phy: Add common Innosilicon HDMI PHY helpers

[Chaoyi Chen]

Hello Michal,

On 9/4/2026 9:27 PM, Michal Wilczynski wrote:
> The Innosilicon HDMI PHY IP is used by several SoCs. They differ in
> where the PHY register block sits in the register space and in which
> pixel clocks they support, but the pre-PLL programming sequence and the
> layout of its registers are the same.
> 
> Add a small library holding that shared part: the pre-PLL configuration
> table format, a lookup, clk_ops determine_rate and recalc_rate helpers,
> and the pre-PLL register programming. Callers pass a regmap, a register
> offset for the PHY block, and their own pixel clock table.
> 
> No driver uses it yet; the users are converted separately.
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> ---
>  drivers/phy/Kconfig               |   8 +
>  drivers/phy/Makefile              |   1 +
>  drivers/phy/phy-inno-hdmi.c       | 298 ++++++++++++++++++++++++++++++++++++++
>  include/linux/phy/inno-hdmi-phy.h |  85 +++++++++++
>  4 files changed, 392 insertions(+)
Reviewed-by: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>

-- 
Best, 
Chaoyi