Re: [PATCH v3 1/4] serial: revert guards in uart_wait_modem_status()

[Jiri Slaby]

On 07. 09. 26, 8:47, Jiri Slaby wrote:
> On 07. 09. 26, 8:44, Johan Hovold wrote:
> > Mixing scope-based and regular cleanup is discouraged and
> > uart_port_deref() used by uart_wait_modem_status() falls in the latter
> > category.
> >
> > Revert the premature guard conversion in preparation for fixing a hangup
> > race.
>
> It's not premature. Just convert uart_port_ref() to guards too. Gotos suck.

(Or don't use gotos and I will.)

--
js
suse labs