Re: [RESEND PATCH] thermal: of: Match trip property helper types

From: Lukasz Luba

Date: Mon Sep 07 2026 - 03:49:18 EST


Hi Rob,

On 8/31/26 20:42, Rob Herring (Arm) wrote:
The thermal-zone binding defines "temperature" as a signed int32
value and "hysteresis" as an unsigned int32 value. Using helpers with
matching types avoids dt_property_check mismatches and preserves the
signed interpretation needed for trips below zero.

Read "temperature" with the signed helper and keep "hysteresis" on the
unsigned helper using separate typed temporaries before storing them in
the trip structure.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
---
drivers/thermal/thermal_of.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)



I can see you've missed my previous tag, here it is:

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>