Re: [PATCH 1/2] serial: wk2xxx: Add WK2xxx SPI UART driver

[Uwe Kleine-König]

On Fri, Sep 04, 2026 at 03:20:26PM +0800, zjzhao wrote:
> +#include <linux/mod_devicetable.h>
> ...
> +#include <linux/spi/spi.h>

Please rely on <linux/spi/spi.h> to provide spi_device_id and
of_device_id and don't include <linux/mod_devicetable.h>. (Or include
<linux/device-id/of.h> and <linux/device-id/spi.h> if you prefer.)

<linux/mod_devicetable.h> shouldn't be used as it pulls in too many
things and thus introduces many unneeded build dependencies.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature