Re: [PATCH v4 1/3] drm/sched: cache the timeline name to fix a use-after-free
From: Tvrtko Ursulin
Date: Mon Sep 07 2026 - 05:23:01 EST
On 04/09/2026 20:06, Philipp Stanner wrote:
8><
If you can think of a stupid and simple solution, shoot. The only thing
I can think of is moving the string into the dma_fence, as a hard copy
:)
In the mean time, my proposal is to keep aiming for removing
sched_fence->ops->release and fixing pvr and amdgpu.
Fixing the drivers sounds like an obvious thing to try indeed. Along the same lines as it was done for xe and panthor. It is an already established and well understood approach so shouldn't be controversial. After that we can discuss in leisurely pace if something better is possible in the scheduler core.
I understand its amdxdna, nouveau, and msm. Was it attempted so far? Is it significantly more complicated than it was for panthor and xe?
As for regarding the 035219a760ed ("dma-buf: dma-fence: Fix potential NULL pointer dereference") sub-thread - I did not manage to penetrate the consensus there - whether it was established that it needs adding the is signaled check back (with additional memory barriers, like v1 of that patch) or not? Regardless of fixing the drivers or what?
Regards,
Tvrtko