Re: [PATCH v2 0/3] mm: minor janitorial style cleanups
From: Christos Skarlos
Date: Mon Sep 07 2026 - 05:23:18 EST
Hey Vlastimil ,
Understood. Thanks for taking the time to explain the proper scope of the
checkpathc.pl. I will drop this patch and keep the tool strictly for new code
submissions moving forward.
Στις Δευ 7 Σεπ 2026 στις 11:58 π.μ., ο/η Christos Skarlos
<christosskarlos.kernel@xxxxxxxxx> έγραψε:
>
> Hey Vlastimil ,
> Understood. Thanks for taking the time to explain the proper scope of the
> checkpathc.pl. I will drop this patch and keep the tool strictly for new code
> submissions moving forward.
>
> Στις Δευ 7 Σεπ 2026 στις 10:44 π.μ., ο/η Vlastimil Babka (SUSE) <vbabka@xxxxxxxxxx> έγραψε:
>>
>> On 9/5/26 20:31, Christos Skarlos wrote:
>> > This patch series resolves various coding style issues flagged by
>> > checkpatch.pl across mmap.c , vmscan.c and hugetlb.c.
>>
>> Checkpatch is meant for avoiding the issues when submitting new patches, not
>> to be run on the existing code to generate fixes just for the checkpatch
>> issues. NAK
>>
>> > Changes in v2:
>> > - Restored filename comment at the top of mmap.c.
>> > - Restore <asm/...> headers in mmap.c as they are architecture-specific.
>> > - Remove blank lines above VMA_ITERATORS and NODEMASK_ALLOC declarations.
>> > - Fixed commit message typos.
>> >
>> >
>> > Thanks for the thorough review and guidance. As a newcomer every
>> > feedback and advice is really valuable to my workflow.
>> >
>> > (Note: Apologies for the stray huge_memory.c patch included in v1 by
>> > accident; this v2 series correctly focuses strictly on mmap, vmscan, and hugetlb.)
>> >
>> > No functional changes are introduced.
>> >
>> > Christos Skarlos (3):
>> > mm/mmap: fix various coding style warnings
>> > mm/vmscan: fix various coding style warnings and errors
>> > mm/hugetlb: fix various coding style warnings.
>> >
>> > mm/hugetlb.c | 16 ++++++++++------
>> > mm/mmap.c | 12 +++++++-----
>> > mm/vmscan.c | 11 ++++++-----
>> > 3 files changed, 23 insertions(+), 16 deletions(-)
>> >
>>