Re: [PATCH] m68k: coldfire: fix typo "reseting" in comment
From: Hemanth Selam
Date: Mon Sep 07 2026 - 05:24:37 EST
On Sun, Sep 06, 2026 at 02:46:04AM -0400, Josh Juran wrote:
> What about the human reviewing its output? Or am I misunderstanding
> the meaning of "Signed-off-by"?
You are not misunderstanding it. My Signed-off-by certifies the DCO,
but sending the patch also means I am answerable for what is in it, and
on this one I did not look hard enough.
The patch came out of a mechanical sweep: checkpatch.pl flags words
listed in scripts/spelling.txt, "reseting" is in that list and
"ColdFure" is not, so nothing pointed at it. That explains why the
tool stopped there. It does not explain why I did not, because the two
words are on the same line and reading the comment was my job.
You caught it, and the v2 fixes both words; Greg has since applied it.
The wider lesson I am taking from this is that a large series does not
get to be reviewed in bulk. Each patch has to be read on its own, in
context, before it goes out, and that is what I will be doing for the
rest of this work.
Thanks for pushing on it rather than letting it through.
Hemanth