Re: [PATCH] arm64: dts: qcom: eliza: Add FastRPC support

[Abel Vesa]

On 26-07-21 16:36:36, Konrad Dybcio wrote:
> On 7/21/26 11:30 AM, Abel Vesa wrote:
> > Describe the glink-edge for CDSP and the FastRPC subnodes for both ADSP
> > and CDSP.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> > FastRPC nodes were not part of the remoteprocs patchsets because they
> > weren't tested in time in order to be sent along.
> > ---
> 
> [...]
> 
> > +				fastrpc {
> > +					compatible = "qcom,fastrpc";
> > +
> > +					qcom,glink-channels = "fastrpcglink-apps-dsp";
> > +
> > +					label = "adsp";
> > +
> > +					qcom,non-secure-domain;
> > +
> > +					#address-cells = <1>;
> > +					#size-cells = <0>;
> > +
> > +					compute-cb@3 {
> > +						compatible = "qcom,fastrpc-compute-cb";
> > +						reg = <3>;
> > +
> > +						iommus = <&apps_smmu 0x1003 0x80>,
> > +							 <&apps_smmu 0x1043 0x20>;
> 
> nit: the doc specifies '0x1063 0x20' etc. for the secondary
> streams. They are of course equivalent with the mask

Sorry for the late reply.

Will use 0x1063 instead.

> 
> [...]
> 
> > +					compute-cb@7 {
> > +						compatible = "qcom,fastrpc-compute-cb";
> > +						reg = <7>;
> > +
> > +						iommus = <&apps_smmu 0x1007 0x40>,
> > +							 <&apps_smmu 0x1067 0x0>,
> > +							 <&apps_smmu 0x1087 0x0>;
> 
> Why does only this one get the tertiary stream?

I'm told that it is for some different subsystem stream which shares the
same address space. But looking through the SID mapping documentation,
it seems this 3rd one is not available on Eliza. So I think I need to drop it.

> 
> [...]
> 
> > +				fastrpc {
> > +					compatible = "qcom,fastrpc";
> > +					qcom,glink-channels = "fastrpcglink-apps-dsp";
> > +					label = "cdsp";
> > +					qcom,non-secure-domain;
> > +					#address-cells = <1>;
> > +					#size-cells = <0>;
> 
> also 0x0c00 @0 I believe?

According to internal doc, there is no S1 compute for this one.