Re: [PATCH v6 01/11] media: rcar-vin: Fix comment related to stride handling

[Niklas Söderlund]

Hi Tomi,

Thanks for your patch.

On 2026-06-17 14:54:54 +0300, Tomi Valkeinen wrote:
> The comment says the stride has to be aligned to 16 bytes, but it should
> be 16 pixels, as VNIS_REG register is in pixels.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> Fixes: 40c6da8a9c0f ("media: renesas: vin: Fix RAW8 (again)")

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> index f9af9177e02f..d6c69c674d57 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> @@ -678,7 +678,7 @@ void rvin_crop_scale_comp(struct rvin_dev *vin)
>  
>  	/*
>  	 * VNIS_REG has four lowest bits always 0, i.e. the stride has to be
> -	 * aligned to 16 bytes. This is done in rvin_format_bytesperline().
> +	 * aligned to 16 pixels. This is done in rvin_format_bytesperline().
>  	 */
>  
>  	fmt = rvin_format_from_pixel(vin, vin->format.pixelformat);
> 
> -- 
> 2.43.0
> 

-- 
Kind Regards,
Niklas Söderlund