Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings

[Ratheesh Kannoth]

On 2026-09-07 at 12:53:15, Leon Romanovsky (leon@xxxxxxxxxx) wrote:
> On Mon, Sep 07, 2026 at 09:58:27AM +0530, Ratheesh Kannoth wrote:
> > From: Hariprasad Kelam <hkelam@xxxxxxxxxxx>
> >
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> > @@ -1231,6 +1231,8 @@ static int otx2_get_link_ksettings(struct net_device *netdev,
> >  				OTX2_MODE_SUPPORTED, cmd);
> >  	otx2_get_fec_info(rsp->fwdata.supported_fec,
> >  			  OTX2_MODE_SUPPORTED, cmd);
> > +
> > +	cmd->base.port = (u8)rsp->fwdata.port;
>
> You should declare identical fields with the same type and avoid silently
> casting variables.
>
> Thanks
You are suggesting to split rsp->fwdata.port to  u8 port + 7-byte pad ?
Currently FW is writing as 64bit.

>
> >  	return 0;
> >  }
> >
> > --
> > 2.43.0
> >
> >