Re: [PATCH 1/2] scripts: add TOML config to container tool

[Guillaume Tucker]

On 03/09/2026 22:27, Nathan Chancellor wrote:
> On Wed, Sep 02, 2026 at 12:26:29PM +0200, Guillaume Tucker wrote:
>> So to recap, here's what I would suggest:
>>
>> * keep Python 3.10 for this series, continue discussion about minimum
>>   and optional version numbers tree-wide in other threads

Sorry I meant Python 3.11 as the minimum version for this series so
we can have TOML support from the standard library.

>> * drop registry config file option in v4 then add it in a follow-up
>>   series along with image name validation and parsing using regex

Done in v4 which I just sent, will send the follow-up once this
series is all done.

>> * leave TypeError exceptions as-is in this series, improve user
>>   experience and error handling altogether in another follow-up
> 
> Sure, I think this sounds fine. I tend to ignore existing issue comments
> from Sashiko when it comes to accepting a series, I would always prefer
> them to be handled in a separate series.

Thanks for confirming, makes sense.

Latest Sashiko review for the v4:

  https://sashiko.dev/#/patchset/68b14a76a4cb2e6437c869bab948983a98acffbd.1788779245.git.gtucker%40gtucker.io

The `env_file` comment is moot as the user should be able to trust
the config file provided.  It's exactly like the classic
docker-compose.yaml env_file use case in fact.

The other comment about injecting options in the image name is also
partly moot as the arguments passed to the subprocess wouldn't work,
still I'm going to be addressing this by validating the image name in
the follow-up series so that should then get resolved anyway.

Best wishes,
Guillaume