Re: [PATCH v3 04/12] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Refactor init regs table definitions
From: Manivannan Sadhasivam
Date: Mon Sep 07 2026 - 07:44:46 EST
On Tue, Aug 25, 2026 at 04:37:21PM +0400, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
>
> Refactor the IPQ5018/IPQ5332 UNIPHY PCIe init data by introducing a
> helper macro for register/value entries and converting open-coded struct
> initializers to the compact form.
>
> Also remove an unused include, drop unused macro register definitions,
> and rename the IPQ5332-specific PHY CFG register macros to make their
> combo PCIe/USB3 scope explicit.
>
These should be part of a separate change. A patch should only do one thing, not
multiple.
- Mani
--
மணிவண்ணன் சதாசிவம்