Re: [PATCH v4 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding
From: Harendra Gautam
Date: Mon Sep 07 2026 - 07:56:19 EST
On Mon, Sep 7, 2026 at 2:04 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 07/09/2026 10:30, Krzysztof Kozlowski wrote:
> > On Thu, Sep 03, 2026 at 12:58:52PM +0530, Harendra Gautam wrote:
> >>
> >> Add the Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI
> >
> > Why do your commits have leading blank line? I mean, really, how is it
> > possible to create such commit?
> >
> > Additionally, way you send your work is making this unnecessarily
> > difficult for us. Look, does this work?
> >
> > b4 diff '20260903072902.3870009-2-harendra.gautam@xxxxxxxxxxxxxxxx'
> >
> > ? No, it does not:
> >
>
> And now I checked... and you did not even use b4 to send v3 and v4. I
> mean, really... why? All internal guides, all external presentations
> EVERYWHERE we say this is expected and even almost a must for bigger work.
Apologies for that. This is my first upstream series and I was not
aware of the b4 send requirement at the time. v3 and v4 were sent via
git send-email. v5 will be sent via b4 send.
-Harendra
>
> Best regards,
> Krzysztof