Re: [PATCH 2/2] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S

[Chukun Pan]

Hi,

> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile

> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-nanopi-r28s.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-nanopi-zero2.dtb

This device tree has many similarities to the nanopi zero2.
Can you create a shared device tree?

> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts

https://wiki.friendlyelec.com/wiki/images/7/7c/NanoPi_R28S_2605_SCH.pdf
Please name the labels according to the schematic.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&user_key>;

Schematic label: GPIO4_B2_USR_BTN

> +		button-reset {
> +			debounce-interval = <50>;
> +			gpios = <&gpio4 RK_PB2 GPIO_ACTIVE_LOW>;
> +			label = "reset";
> +			linux,code = <KEY_RESTART>;

label = "USER";

> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&lan_led_g>, <&sys_led_r>, <&wan_led_g>;

Schematic label: LED1 LED2 LED_SYS

> +	sdio_pwrseq: sdio-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wifi_enable_h>;

Schematic label: PWR_WF

> +&pcie {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pcie_reset_h>;

Schematic label: PCIE_ETH_PERSTB