Re: [PATCH] usb: typec: tipd: Disable mode control for CD321x
From: Heikki Krogerus
Date: Mon Sep 07 2026 - 09:11:32 EST
On Sun, Sep 06, 2026 at 02:24:00PM +0200, Sven Peter wrote:
> Apple's CD321X firmware controls which alternate mode is entered and
> cannot be influenced from Linux. Set the no_mode_control capability to
> accurately reflect this to the typec subsystem.
>
> Signed-off-by: Sven Peter <sven@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/tipd/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 522f56742aa9..8fdb37e288b4 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -151,6 +151,7 @@ struct tipd_data {
> irq_handler_t irq_handler;
> u64 irq_mask1;
> size_t tps_struct_size;
> + bool no_mode_control;
> void (*remove)(struct tps6598x *tps);
> int (*register_port)(struct tps6598x *tps, struct fwnode_handle *node);
> void (*unregister_port)(struct tps6598x *tps);
> @@ -1242,6 +1243,7 @@ tps6598x_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
> typec_cap.driver_data = tps;
> typec_cap.ops = &tps6598x_ops;
> typec_cap.fwnode = fwnode;
> + typec_cap.no_mode_control = tps->data->no_mode_control;
>
> switch (TPS_SYSCONF_PORTINFO(conf)) {
> case TPS_PORTINFO_SINK_ACCESSORY:
> @@ -2015,6 +2017,7 @@ static const struct tipd_data cd321x_data = {
> APPLE_CD_REG_INT_DATA_STATUS_UPDATE |
> APPLE_CD_REG_INT_PLUG_EVENT,
> .tps_struct_size = sizeof(struct cd321x),
> + .no_mode_control = true,
> .remove = cd321x_remove,
> .register_port = cd321x_register_port,
> .unregister_port = cd321x_unregister_port,
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260906-b4-tipd-mode-ctrl-80835d9e3f72
>
> Best regards,
> --
> Sven Peter <sven@xxxxxxxxxx>
>
--
heikki