Re: [PATCH v5] x86/virt/tdx: Formalize SEAMCALL leaf version encoding support

From: Dave Hansen

Date: Mon Sep 07 2026 - 10:49:15 EST


On 9/7/26 04:20, Tony Lindgren wrote:
> /*
> - * Used in __tdcall*() to gather the input/output registers' values of the
> - * TDCALL instruction when requesting services from the TDX module. This is a
> - * software only structure and not part of the TDX module/VMM ABI
> + * Used in __tdcall*() to gather the input/output parameters of the TDCALL
> + * instruction when requesting services from the TDX module. "version" is
> + * encoded in RAX along with the leaf number. Others are raw input/output
> + * registers' values. This is a software only structure and not part of the TDX
> + * module/VMM ABI.
> */

It's a wee bit silly to talk about "version" in here. If you need to
comment on "version" specifically, then put a comment *on* that variable.