Re: [PATCH v2] ARM, ARM64, LONGARCH: Delay HW BP notification to task_work()

[Russell King]

On Fri, Sep 04, 2026 at 05:54:04PM +0200, Sebastian Andrzej Siewior wrote:
> On 2026-09-03 13:31:46 [-0400], Steven Rostedt wrote:
> > On Thu, 3 Sep 2026 17:47:24 +0100
> > Russell King <linux@xxxxxxxxxxxxxxx> wrote:
> > 
> > > What do you expect to happen with this? Which arch maintainer should
> > > apply this patch that affects three different independently maintained
> > > architectures?
> 
> Well, if you as the ARM person are fine with ARM part, an ACK would be
> appreciated. If you have something to object, it would be nice to let me
> know so I can adjust accordingly.

First, I only just looked at the email - you may have noticed I'm not
very active with the kernel anymore, as I'm a full-time carer at the
moment.

Second, I'm not fine with the patch as-is, because it's not clear how
it could be merged in its current form. It would be inappropriate to
give an Ack, because an Ack means I'm fine with it. I'm not.

Third, I haven't actually reviewed the patch itself (see first point).

Looking deeper now, I see nothing in the linked report, nor in your
write-up that identifies what is responsible for the context being
inappropriate to deliver the SIGTRAP. See the first point - I'm not
able to read lots of code to work that out, and presumably you've
already done that ground work to come up with a fix. This is *vital*
information when someone looks back at why this change was made as
it helps to understand how the problem occurs. This is, after all,
the whole point of commit messages - to help people look back and
understand why a change was made. The "what the changes are" part
is already covered by the patch showing what the changes were. It's
the stuff that *isn't* in the patch that needs to be in the commit
message.

So... don't describe the code changes in a commit message.

So no, an Ack is not appropriate.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!